Skip to content

Cookie.php fixed invalid PHPDoc #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2017
Merged

Cookie.php fixed invalid PHPDoc #88

merged 1 commit into from
Nov 25, 2017

Conversation

meridius
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets none
Documentation none
License MIT

What's in this PR?

Fix for invalid PHPDoc

Why?

Parameter $maxAge is nullable and its PHPDoc should reflect that.

Example Usage

none

Checklist

  • Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix
  • Documentation pull request created (if not simply a bugfix)

To Do

none

@meridius
Cookie.php fixed invalid PHPDoc
2cbeffc 
parameter $maxAge is nullable and its PHPDoc should reflect that
@dbu dbu merged commit 977edb5 into php-http:master Nov 25, 2017
@dbu
Copy link
Contributor

dbu commented Nov 25, 2017

thanks!

@meridius meridius deleted the patch-1 branch November 25, 2017 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meridius @dbu